Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors are not shown properly #6

Open
tjventurini opened this issue May 3, 2021 · 2 comments · May be fixed by #12
Open

Errors are not shown properly #6

tjventurini opened this issue May 3, 2021 · 2 comments · May be fixed by #12
Labels
enhancement New feature or request WIP Work in process

Comments

@tjventurini
Copy link

tjventurini commented May 3, 2021 •
edited

First off, thank you for providing this awesome extension 👍

But I'm wondering if the output I get for the found errors is working correctly 🤔

image

As you can see, it is only shown by the little red line on the start of the line. Is that the way it is supposed to be?

I would prefer it if it would highlight the whole line or the portion of it that is wrong. Is it possible to do so?

Thank you! 😁
@mikeybinns
Copy link

I was also looking into this, but I think part of the problem is PHPStan only provides the line number, not the line column (aka. where on the line is the error) like some other error checkers do.

You might have some luck using the Problems tab instead of relying on the line highlighting, as that will show you all the errors from the file? I know that's not ideal, maybe send a feature request to PHPStan directly.

@tjventurini
Copy link
Author

But the other extensions (you know, the ones that don't have the watch function 😏) show the error properly 🤔

I guess I'm going to take a look at it this weekend too. Maybe I can gather some info 🤓

rush93 added a commit to restarteco/phpstan-vscode that referenced this issue Aug 31, 2022
@rush93
change error display length on all line instead of first char (issue: s…
8743761 
…wordev#6)
@rush93 rush93 linked a pull request Aug 31, 2022 that will close this issue
Open
@juanrgm juanrgm added enhancement New feature or request WIP Work in process labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request WIP Work in process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change error display length on all line instead of first char restarteco/phpstan-vscode
3 participants
@tjventurini @mikeybinns @juanrgm