Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Bump Node to 16 #485

Merged
merged 1 commit into from Oct 13, 2022
Merged

BREAKING: Bump Node to 16 #485

merged 1 commit into from Oct 13, 2022

Conversation

BeyondEvil
Copy link
Contributor

Github Actions are deprecating the use of Node12 in Actions.

Fixes: #484

@moyerr moyerr mentioned this pull request Oct 12, 2022
Closed
@fwal
Copy link
Collaborator

fwal commented Oct 13, 2022

Hej @BeyondEvil! 👋🏻

Thanks for the PR!
Perhaps we should also define node version in package.json or npmrc to make sure that it's built correctly?

@BeyondEvil
Copy link
Contributor Author

BeyondEvil commented Oct 13, 2022 •
edited

Hej hej 😊 @fwal 👋

Updated. Lmk what you think. 👍

dist/index.js is tracked, is that by design?

@fwal
Copy link
Collaborator

fwal commented Oct 13, 2022

Thanks!

Yeah, unfortunately dist needs to be tracked for GitHub Actions but they shouldn't be included in PRs (deploy will manage that).

@BeyondEvil
Copy link
Contributor Author

Ah, got it.

I'll remove it from the PR then! 👍

@fwal fwal added the enhancement New feature or request label Oct 13, 2022
@BeyondEvil
Copy link
Contributor Author

Done!

Got a bit lost in Git resets/restores, but I think I solved it. 😅

fwal
fwal approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@fwal fwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@fwal fwal merged commit f6b3eb2 into swift-actions:main Oct 13, 2022
@BeyondEvil BeyondEvil deleted the beyondevil/bump-node-to-16 branch October 13, 2022 09:15
@fwal
Copy link
Collaborator

fwal commented Oct 31, 2022

Forgot to push out the release 😬 - it's out now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwal fwal fwal approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Actions are deprecating Node 12
2 participants
@BeyondEvil @fwal