Skip to content

fix(es/minifier): Drop unused import bindings #6967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

magic-akari
Copy link
Member

Description:
It is always safe to remove unused import bindings and keep import statements to preserve side effects.
This transformation does not require additional options like drop_unused_imports.

BREAKING CHANGE:

Related issue (if exists):

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_ecma_transforms_optimization

@kdy1 kdy1 added this to the Planned milestone Feb 20, 2023
@kdy1 kdy1 enabled auto-merge (squash) February 20, 2023 06:50
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a27ffd2 into swc-project:main Feb 21, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.36 Feb 21, 2023
@magic-akari magic-akari deleted the es/minify/unused-import-bindings branch March 10, 2023 02:51
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants