Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Fix syntax context of async-to-generator #6741

Merged
merged 13 commits into from Jan 3, 2023
Merged

fix(es/compat): Fix syntax context of async-to-generator #6741

merged 13 commits into from Jan 3, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 3, 2023 •
edited

Description:

Previously, the async-to-generator produced invalid AST, in aspect of span hygiene.
Playground.
It generate two bindings for args so it's invalid.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jan 3, 2023
@kdy1 kdy1 self-assigned this Jan 3, 2023
@kdy1 kdy1 changed the title fix(es/helpers): Fix syntax hygiene of helpers fix(es/helpers): Fix syntax context of helpers Jan 3, 2023
@kdy1 kdy1 changed the title fix(es/helpers): Fix syntax context of helpers fix(es/helper): Fix syntax context of helpers Jan 3, 2023
@kdy1 kdy1 changed the title fix(es/helper): Fix syntax context of helpers fix(es/transform): Fix syntax context of async-to-generator Jan 3, 2023
@kdy1 kdy1 changed the title fix(es/transform): Fix syntax context of async-to-generator fix(es/compat): Fix syntax context of async-to-generator Jan 3, 2023
@kdy1 kdy1 marked this pull request as ready for review January 3, 2023 04:45
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 3, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 3, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 3, 2023 04:45
kdy1
kdy1 commented Jan 3, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_utils

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 3, 2023
View reviewed changes
@kdy1 kdy1 merged commit 206c0db into swc-project:main Jan 3, 2023
@kdy1 kdy1 deleted the issue-6730 branch January 3, 2023 09:45
@kdy1 kdy1 modified the milestones: Planned, v1.3.25 Jan 5, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.25
Development

Successfully merging this pull request may close these issues.

minify.mangle causes variable confusion
1 participant
@kdy1