Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Use the compile --source-maps option #6708

Merged
merged 2 commits into from Dec 23, 2022

Conversation

realtimetodie
Copy link
Contributor

@realtimetodie realtimetodie commented Dec 21, 2022

Fixes an issue where the source maps are not generated when using the cli compile command with the --source-maps option and without providing a configuration file.

The validation handling is passed down

SourceMapsConfig::Str(ref s) => {
assert_eq!(s, "inline", "Source map must be true, false or inline");
true
}

Example

$ swc compile --source-maps=true --source-map-target=output.js.map --out-file=output.js input.js

Actual behavior

output.js

Expected behavior

output.js
output.js.map

Related

@kdy1 kdy1 added this to the Planned milestone Dec 22, 2022
@kdy1 kdy1 requested a review from kwonoj December 22, 2022 01:37
@kdy1 kdy1 self-assigned this Dec 22, 2022
@kdy1 kdy1 enabled auto-merge (squash) December 23, 2022 02:22
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1
Copy link
Member

kdy1 commented Dec 23, 2022

@realtimetodie Can you check allow edit by maintainers? I think it's required for the bot to auto-rebase

@realtimetodie
Copy link
Contributor Author

Yes

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 24cd384 into swc-project:main Dec 23, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.25 Jan 5, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants