Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Don't inline invalid LHS into an update argument #6680

Merged
merged 6 commits into from Dec 20, 2022
Merged

fix(es/minifier): Don't inline invalid LHS into an update argument #6680

merged 6 commits into from Dec 20, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 19, 2022

@kdy1 kdy1 added this to the Planned milestone Dec 19, 2022
@kdy1 kdy1 marked this pull request as ready for review December 19, 2022 06:08
kdy1
kdy1 commented Dec 19, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 changed the title fix(es/minifier): Don't inline into an update argument fix(es/minifier): Don't inline invalid LHS into an update argument Dec 19, 2022
@kdy1 kdy1 enabled auto-merge (squash) December 20, 2022 05:14
swc-bot
swc-bot reviewed Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment •
edited by kdy1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

--

--

reset ci

swc-bot
swc-bot reviewed Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 7e6ec8d into swc-project:main Dec 20, 2022
@kdy1 kdy1 deleted the issue-6641 branch December 20, 2022 07:45
@kdy1 kdy1 modified the milestones: Planned, 1.3.24 Dec 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@jridgewell jridgewell jridgewell approved these changes

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@jridgewell jridgewell

@kdy1 kdy1

Labels
None yet
Milestone
1.3.24
Development

Successfully merging this pull request may close these issues.

Self invoked function param being incorrectly inlined in ES2015+
3 participants
@kdy1 @jridgewell @swc-bot