Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make injected core-js@3.x polyfills align with @babel/plugin-polyfill-corejs3 #6673

Merged
merged 2 commits into from Dec 19, 2022
Merged

Make injected core-js@3.x polyfills align with @babel/plugin-polyfill-corejs3 #6673

merged 2 commits into from Dec 19, 2022

Conversation

JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Dec 18, 2022 •
edited

Description:

This PR is to remove the redundant polyfills, to make behavior align with babel polyfills.

You can find difference of polyfills between babel and swc,

The differences are:

esnext.aggregate-error.js
esnext.array.at.js
esnext.global-this.js
esnext.object.has-own.js
esnext.promise.all-settled.js
esnext.promise.any.js
esnext.string.match-all.js
esnext.string.replace-all.js
esnext.typed-array.at.js

In @babel/plugin-polyfill-corejs3, feature that has both esnext prefix and es prefix will be removed, you can find that here.

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 self-assigned this Dec 19, 2022
@kdy1 kdy1 added this to the Planned milestone Dec 19, 2022
kdy1
kdy1 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_preset_env

@kdy1 kdy1 enabled auto-merge (squash) December 19, 2022 04:27
swc-bot
swc-bot reviewed Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 5fed222 into swc-project:main Dec 19, 2022
@kdy1 kdy1 modified the milestones: Planned, 1.3.24 Dec 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
1.3.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JSerFeng @kdy1 @swc-bot