feat(css/parser): normalize declaration and important #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Dec 15, 2022
| minified.push((chars[0] as char).to_ascii_lowercase()); | ||
| minified.push((chars[2] as char).to_ascii_lowercase()); | ||
| minified.push((chars[4] as char).to_ascii_lowercase()); | ||
| minified.push((chars[6] as char).to_ascii_lowercase()); |
There was a problem hiding this comment.
Forgot to remove it too, we don't need it, because we already normalize hex colors
alexander-akait
commented
Dec 15, 2022
alexander-akait
force-pushed
the
feat-normalize-declarations
branch
from
68bbecf
to
97bb06f
Compare
kdy1
approved these changes
Dec 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Normalize declartion and important, also found a bug in
swc_css_prefixer(because we don't check case) and fixedBREAKING CHANGE:
No
Related issue (if exists):
No