Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Abort IIFE invoker completely on eval #6659

Merged
merged 12 commits into from Dec 15, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 15, 2022

Description:

The previous patch was not enough

Related issue:

@kdy1 kdy1 added this to the Planned milestone Dec 15, 2022
@kdy1 kdy1 requested a review from jridgewell December 15, 2022 03:41
@kdy1 kdy1 self-assigned this Dec 15, 2022
@kdy1 kdy1 marked this pull request as ready for review December 15, 2022 03:41
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@@ -0,0 +1,13 @@
!function() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous: SWC playground

@kdy1 kdy1 enabled auto-merge (squash) December 15, 2022 05:16
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit bb9fab8 into swc-project:main Dec 15, 2022
@kdy1 kdy1 deleted the iife branch December 15, 2022 07:50
@kdy1 kdy1 modified the milestones: Planned, 1.3.24 Dec 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

minify wrongly transform inner scope variable to global scope variable
3 participants