New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/minifier): Abort sequential inliner on optional chaining #6637
Conversation
react-table
react-table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_ecma_minifier
@@ -0,0 +1,8 @@ | |||
export function memo(getDeps, fn, opts) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous output:
export function memo(getDeps, fn, opts) {
let result, deps = [];
return ()=>{
opts.key && opts.debug && Date.now();
const newDeps = getDeps(), depsChanged = newDeps.length !== deps.length || newDeps.some((dep, index)=>deps[index] !== dep);
return depsChanged && (deps = newDeps, opts.key && opts.debug && Date.now(), opts?.onChange?.(result = fn(...newDeps)), opts.key && opts.debug && opts?.debug()), result;
};
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,8 @@ | |||
export function memo(getDeps, fn, opts) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
Description:
I'm currently reducing it.
Related issue:
@tanstack/react-table
#6636.Investigation
prints
undefined
.Works