Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): fix issue with typescript's mapped types output #6621

Merged
merged 1 commit into from Dec 12, 2022
Merged

fix(es/codegen): fix issue with typescript's mapped types output #6621

merged 1 commit into from Dec 12, 2022

Conversation

kevinbarabash
Copy link
Contributor

@kevinbarabash kevinbarabash commented Dec 11, 2022 •
edited by alexander-akait

Description:

In some situations the code generated for mapped types would include a / instead of a ?.

BREAKING CHANGE:

This is a small bug fix and shouldn't be breaking change.

Related issue (if exists):

fixes #6616

@kdy1 kdy1 added this to the Planned milestone Dec 12, 2022
kdy1
kdy1 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 enabled auto-merge (squash) December 12, 2022 01:57
@kdy1 kdy1 merged commit 5c53a74 into swc-project:main Dec 12, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.23 Dec 14, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.23
Development

Successfully merging this pull request may close these issues.

swc_ecma_codegen emits / in some mapped types
2 participants
@kevinbarabash @kdy1