Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-swc): Add missing const_to_let to the type #6615

Merged
merged 1 commit into from Dec 11, 2022
Merged

fix(node-swc): Add missing const_to_let to the type #6615

merged 1 commit into from Dec 11, 2022

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Dec 11, 2022 •
edited

Description:

swc/crates/swc_ecma_minifier/src/option/terser.rs

Lines 243 to 244 in a5efa8a

#[serde(default)]
pub const_to_let: Option<bool>,

SWC has const_to_let, but it is missing in the type.

BREAKING CHANGE:

Related issue (if exists):

@SukkaW SukkaW changed the title fix(node-swc): Add missing const_to_let fix(node-swc): Add missing const_to_let to the type Dec 11, 2022
@kdy1 kdy1 self-assigned this Dec 11, 2022
@kdy1 kdy1 added this to the Planned milestone Dec 11, 2022
@kdy1 kdy1 enabled auto-merge (squash) December 11, 2022 09:00
kdy1
kdy1 approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 merged commit 7e841a5 into swc-project:main Dec 11, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.23 Dec 14, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.23
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SukkaW @kdy1