fix(ecma/parser): parse types in CallExpression inside templates
#6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
changed the title
CallExpression inside templates
alexander-akait
commented
Dec 9, 2022
| @@ -841,7 +844,6 @@ impl<I: Tokens> Parser<I> { | |||
| let return_type = if !self.ctx().will_expect_colon_for_cond | |||
| && self.input.syntax().typescript() | |||
| && is!(self, ':') | |||
| && !self.ctx().dont_parse_colon_as_type_ann | |||
There was a problem hiding this comment.
I think we don't need dont_parse_colon_as_type_ann, because will_expect_colon_for_cond is used to check should we parse : as type or not, also I found we duplicate logic, i.e. we set will_expect_colon_for_cond and dont_parse_colon_as_type_ann to the same value (except switch logic, but I found it is not used there plus I added test cases)
alexander-akait
changed the title
CallExpression inside templatesCallExpression inside templates
kdy1
approved these changes
Dec 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
#6601
BREAKING CHANGE:
No
Related issue (if exists):
Fixed #6601