fix(ecma/codegen): don't print trailing coma for rest argument #6610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
issue-6589
branch
from
f9d831e
to
3d0b652
Compare
alexander-akait
commented
Dec 9, 2022
| }; | ||
| let bar = { | ||
| bar: "baz", | ||
| ...other |
There was a problem hiding this comment.
ES2022 allows trailing comma here, but we don't have an option to force enable/disable it (or we can print it when it supported, but currently we don't use this logic), so I think we should solve it in the separated PR
alexander-akait
commented
Dec 9, 2022
kdy1
approved these changes
Dec 10, 2022
swc-bot
reviewed
Dec 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
#6589
BREAKING CHANGE:
No
Related issue (if exists):
Fixed #6589