Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(es/typescript): Migrate inline tests to fixture tests #6546

Merged
merged 20 commits into from Nov 30, 2022
Merged

test(es/typescript): Migrate inline tests to fixture tests #6546

merged 20 commits into from Nov 30, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 30, 2022

Description:

@kdy1 kdy1 added this to the Planned milestone Nov 30, 2022
@kdy1 kdy1 self-assigned this Nov 30, 2022
kdy1
kdy1 commented Nov 30, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as a breaking change due to my previous mistakes

swc-bump:

  • swc_ecma_ast --breaking
  • swc_css_ast --breaking

@kdy1 kdy1 marked this pull request as ready for review November 30, 2022 05:52
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 30, 2022
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) November 30, 2022 05:52
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 30, 2022
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 30, 2022
View reviewed changes
swc-bot
swc-bot reviewed Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit cddbc41 into swc-project:main Nov 30, 2022
@kdy1 kdy1 deleted the transform-fixture branch November 30, 2022 07:46
@kdy1 kdy1 modified the milestones: Planned, v1.3.21 Nov 30, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.21
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @swc-bot