fix(es/minifier): Make sequential inliner respect resolution order #6509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
changed the title
react-joyride![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
jridgewell
reviewed
Nov 28, 2022
| // See https://github.com/swc-project/swc/pull/6509 | ||
|
|
||
| // We check only for an identifier because resolution is the problematic part. | ||
| // Evalutation order is not a problem. |
There was a problem hiding this comment.
Is this true? Wouldn't (1, obj)[obj = {}, 'key'] hit the same problem?
There was a problem hiding this comment.
Oh, I was wrong. Nice catch, and thank you!
jridgewell
approved these changes
Nov 29, 2022
swc-bot
reviewed
Nov 29, 2022
swc-bot
reviewed
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue:
Investigation
This requires
inline,sequencesandconditionalobjofMemberExpris resolved firstSo the code below is invalid, because
fragmentsof fragments[...]` is undefined, even if it's reassigned