Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(binding/wasm): use binding_macro #6487

Merged
merged 1 commit into from Nov 21, 2022
Merged

refactor(binding/wasm): use binding_macro #6487

merged 1 commit into from Nov 21, 2022

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Nov 21, 2022

Description:

I think I did this before 馃 somehow wasm binding doesn't use macros. Trying to reapply.

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Nov 21, 2022
@kdy1 kdy1 self-assigned this Nov 21, 2022
kdy1
kdy1 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 enabled auto-merge (squash) November 21, 2022 01:12
@kdy1 kdy1 merged commit d957aac into swc-project:main Nov 21, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.20 Nov 26, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.20
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwonoj @kdy1