Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): scope pr trigger type #6486

Merged
merged 2 commits into from Nov 21, 2022
Merged

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Nov 20, 2022

Description:

Curious if we're interested in having reduced scope to trigger pr workflow? currently it is wide, runs all CI workflow for the commit / pr both when new commit's being updated in pull request. synchronize supposed to do the work for the pr, while we keep main branch push behavior as is.

ref: https://github.com/vercel/next.js/blob/canary/.github/workflows/build_test_deploy.yml#L3-L5

BREAKING CHANGE:

Related issue (if exists):

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • dbg-swc

@kdy1 kdy1 added this to the Planned milestone Nov 21, 2022
@kdy1 kdy1 enabled auto-merge (squash) November 21, 2022 00:20
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 7fe091a into swc-project:main Nov 21, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.20 Nov 26, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants