Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): should preserve classes with side effects in static fields #6480

Merged
merged 3 commits into from Nov 24, 2022

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented Nov 19, 2022

Description:

BREAKING CHANGE:

Related issue (if exists):

Fix #5588.

@kdy1 kdy1 added this to the Planned milestone Nov 19, 2022
@kdy1 kdy1 self-assigned this Nov 19, 2022
@hyf0 hyf0 marked this pull request as ready for review November 19, 2022 13:21
@hyf0 hyf0 force-pushed the hyf_minify_static_block_2 branch 3 times, most recently from 9ba2288 to 91dcf6e Compare November 21, 2022 02:56
@kdy1 kdy1 requested a review from jridgewell November 21, 2022 10:07
jridgewell
jridgewell previously approved these changes Nov 21, 2022
@hyf0 hyf0 force-pushed the hyf_minify_static_block_2 branch 2 times, most recently from 8a98e29 to 0375eca Compare November 24, 2022 02:30
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 enabled auto-merge (squash) November 24, 2022 09:42
@kdy1 kdy1 merged commit 8d906b4 into swc-project:main Nov 24, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.20 Nov 26, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Minifier should preserve classes with a side effect in a static block
3 participants