Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): should not drop statements which has side-effects #6476

Merged
merged 9 commits into from Nov 20, 2022

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented Nov 18, 2022

Description:

BREAKING CHANGE:

Related issue (if exists):

Fix #6422

@hyf0 hyf0 marked this pull request as ready for review November 18, 2022 13:24
@kdy1 kdy1 added this to the Planned milestone Nov 18, 2022
@kdy1 kdy1 self-assigned this Nov 19, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm leaving a bump comment to avoid forgetting correct bump.


swc-bump:

  • swc_atoms

crates/swc_ecma_utils/src/lib.rs Outdated Show resolved Hide resolved
crates/swc_ecma_utils/src/lib.rs Outdated Show resolved Hide resolved
crates/swc_ecma_utils/src/lib.rs Outdated Show resolved Hide resolved
@kdy1 kdy1 requested a review from jridgewell November 19, 2022 14:59
@kdy1 kdy1 enabled auto-merge (squash) November 20, 2022 00:26
@kdy1 kdy1 merged commit 9154bbc into swc-project:main Nov 20, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.19 Nov 20, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Minifier doesn't respect side-effect in getter or setter
3 participants