Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bindings/wasm): deprecate jsvalue::*_serde #6462

Merged
merged 8 commits into from Nov 18, 2022

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Nov 16, 2022

Description:

Second attempts to #6436, with various fixes to ensure things are not breaking.

PR also adds naive testing to swc_core to test with latest workspace root to build. This allows to catch problems upfront before publish swc_core (not @swc/core). It actually caught various failures while I'm working on this PR.

Also, PR updates bindings_macro to reflect latest changes.

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Nov 17, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • binding_macros

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merge conflict

@kwonoj
Copy link
Member Author

kwonoj commented Nov 17, 2022

Thanks, looks like rebased on passes ci now.

@kdy1 kdy1 enabled auto-merge (squash) November 17, 2022 02:00
kdy1
kdy1 previously approved these changes Nov 17, 2022
@kwonoj
Copy link
Member Author

kwonoj commented Nov 17, 2022

I recall I resolved conflicts.. 🤔 anyway, re-rebased.

@kdy1 kdy1 merged commit dd4b9e8 into swc-project:main Nov 18, 2022
@kwonoj kwonoj deleted the redux-refactor-break-serde branch November 18, 2022 04:54
@kdy1 kdy1 modified the milestones: Planned, v1.3.19 Nov 20, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants