Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbg-swc): Remove comments from the output of terser #6119

Merged
merged 2 commits into from Oct 11, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 11, 2022

Description:

This PR removes comments by parsing and printing using swc APIs because the comments disturb looking at diffs.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Oct 11, 2022
@kdy1 kdy1 self-assigned this Oct 11, 2022
@kdy1 kdy1 marked this pull request as ready for review October 11, 2022 09:06
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 11, 2022
@kdy1 kdy1 enabled auto-merge (squash) October 11, 2022 09:06
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 disabled auto-merge October 11, 2022 10:42
@kdy1 kdy1 merged commit 8549c47 into swc-project:main Oct 11, 2022
@kdy1 kdy1 deleted the minifier-7 branch October 11, 2022 10:43
@kdy1 kdy1 modified the milestones: Planned, v1.3.7 Oct 12, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant