Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css/parser): prepare AST types for gradients #6111

Merged
merged 4 commits into from Oct 11, 2022
Merged

feat(css/parser): prepare AST types for gradients #6111

merged 4 commits into from Oct 11, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Oct 10, 2022 •
edited

Description:

More AST types - https://www.w3.org/TR/css-values-4/#mixed-percentages.

We need this for parsing gradients - https://w3c.github.io/csswg-drafts/css-images-3/#typedef-color-stop-list

Plus future tests to see changes

BREAKING CHANGE:

Yes

Related issue (if exists):

No

@alexander-akait alexander-akait changed the title Feat parse gradients feat(css/parser): prepare AST types for gradients Oct 10, 2022
@kdy1 kdy1 self-assigned this Oct 11, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 11, 2022
kdy1
kdy1 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_ast --breaking

@kdy1 kdy1 enabled auto-merge (squash) October 11, 2022 04:30
swc-bot
swc-bot reviewed Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge October 11, 2022 05:35
@kdy1 kdy1 merged commit 6b3f4bb into swc-project:main Oct 11, 2022
@alexander-akait alexander-akait deleted the feat-parse-gradients branch October 11, 2022 11:46
@kdy1 kdy1 modified the milestones: Planned, v1.3.7 Oct 12, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot