Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/minifier): Inline pure array literal partially #6099

Merged
merged 15 commits into from Oct 12, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 10, 2022

Description:

function f() {
    var a = [94, 173, 190, 239];
    var b = 0;
    b |= a[0];
    b <<= 8;
    b |= a[1];
    b <<= 8;
    b |= a[2];
    b <<= 8;
    b |= a[3];
    return b;
}
console.log(f().toString(16));

This can be precomputed.

Related issue:

@kdy1 kdy1 force-pushed the minifier-3 branch 2 times, most recently from c44012d to 72bfe79 Compare October 10, 2022 07:53
@kdy1 kdy1 self-assigned this Oct 10, 2022
@kdy1 kdy1 requested a review from jridgewell October 10, 2022 08:07
@kdy1 kdy1 marked this pull request as ready for review October 10, 2022 08:07
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 10, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 10, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 10, 2022
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we expand this to operate on regular objects as well?

@kdy1 kdy1 enabled auto-merge (squash) October 12, 2022 01:53
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 66196a6 into swc-project:main Oct 12, 2022
@kdy1 kdy1 deleted the minifier-3 branch October 12, 2022 02:29
@kdy1 kdy1 modified the milestones: Planned, v1.3.7 Oct 12, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants