Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change file extension in TypeScript example #6094

Merged
merged 2 commits into from Oct 10, 2022
Merged

chore: change file extension in TypeScript example #6094

merged 2 commits into from Oct 10, 2022

Conversation

amorriscode
Copy link
Contributor

@amorriscode amorriscode commented Oct 9, 2022 •
edited

Description:

I was browsing the examples and notices the file extension for the TypeScript example was *.js so I updated them to *.ts.

@amorriscode
chore: change file extension in TypeScript example
8a1ecb0 
I was browsing the examples and notices the file extension for the TypeScript example was `*.js` so I updated them to `*.ts`.
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kdy1 kdy1 self-assigned this Oct 10, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 10, 2022
kdy1
kdy1 approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • dbg-swc

@kdy1 kdy1 enabled auto-merge (squash) October 10, 2022 04:31
swc-bot
swc-bot reviewed Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit ca67d52 into swc-project:main Oct 10, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.7 Oct 12, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amorriscode @CLAassistant @kdy1 @swc-bot