feat(es/minifier): Inline lazy inited vars in condition #6089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austaras
commented
Oct 8, 2022
| e.get_mut().cond_init |= if !inited && e.get().var_initialized { | ||
| true | ||
| } else { | ||
| var_info.cond_init | ||
| }; | ||
| if var_info.var_initialized { | ||
| if e.get().var_initialized || e.get().ref_count > 0 { |
There was a problem hiding this comment.
This line needs to happen before ref_count merge and after cond_init merge
|
Sorry, I rebased this (to make it reviewable) because I made a mistake while trying codeball |
kdy1
previously approved these changes
Oct 8, 2022
jridgewell
suggested changes
Oct 8, 2022
Austaras
requested review from
kdy1 and
jridgewell
and removed request for
kdy1 and
jridgewell
kdy1
approved these changes
Oct 9, 2022
jridgewell
approved these changes
Oct 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
At the time of writing #5737, I thought such case would be rare. That is wrong.
BREAKING CHANGE:
Related issue (if exists):