Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Fix infection analysis of sequential inliner #6053

Merged
merged 6 commits into from Oct 6, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 5, 2022

Description:

cc @Austaras

This is another version of the fix for the callee issue, which is done by fixing the infection analyzer.

But this also regresses a lot. So let's compare...

Related issue:

@kdy1 kdy1 added this to the Planned milestone Oct 5, 2022
@kdy1 kdy1 self-assigned this Oct 5, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Fix sequential inliner - TRY 2 fix(es/minifier): Fix infection analysis of sequential inliner Oct 5, 2022
@kdy1
Copy link
Member Author

kdy1 commented Oct 5, 2022

Undrafting as this seems like a more logical (minimal) fix.

@kdy1 kdy1 marked this pull request as ready for review October 5, 2022 13:59
@kdy1 kdy1 requested a review from jridgewell October 5, 2022 14:01
@kdy1 kdy1 enabled auto-merge (squash) October 6, 2022 01:33
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit d65fba1 into swc-project:main Oct 6, 2022
@kdy1 kdy1 deleted the issue-6047 branch October 6, 2022 02:46
@kdy1 kdy1 modified the milestones: Planned, v1.3.5 Oct 6, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

minifier should not skip callee in more cases
3 participants