Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Fix handling of op-assignment in generator #6036

Merged
merged 5 commits into from Oct 4, 2022
Merged

fix(es/compat): Fix handling of op-assignment in generator #6036

merged 5 commits into from Oct 4, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 4, 2022

@kdy1 kdy1 added this to the Planned milestone Oct 4, 2022
@kdy1 kdy1 self-assigned this Oct 4, 2022
@kdy1 kdy1 changed the title fix(es/compat): Fix generator pass fix(es/compat): Fix handling of op-assignment in generator Oct 4, 2022
@kdy1 kdy1 marked this pull request as ready for review October 4, 2022 14:44
@kdy1 kdy1 enabled auto-merge (squash) October 4, 2022 14:44
kdy1
kdy1 commented Oct 4, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_compat

swc-bot
swc-bot reviewed Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 7554482 into swc-project:main Oct 4, 2022
@kdy1 kdy1 deleted the issue-5994 branch October 4, 2022 15:17
@kdy1 kdy1 modified the milestones: Planned, v1.3.5 Oct 6, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.5
Development

Successfully merging this pull request may close these issues.

Appending the result of an async function to a string in an async function generates invalid code
2 participants
@kdy1 @swc-bot