New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/compat): counteract unrolling of awaited async arrays in generator #5965
fix(es/compat): counteract unrolling of awaited async arrays in generator #5965
Conversation
|
…on in array to counter unwrapping done by concat
bb016f7
to
2809687
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
swc-bump:
- swc_ecma_transforms_compat
Description:
This is a workaround addressing the issue #5951 by wrapping the arguments of the
.concat
call in individual arrays to counteract the unrolling done byconcat
.A different way of handling the problem would be to
push
the arguments to_tmp
before the return statement and then use_tmp
in theapply
call. However I'm not comfortable enough with the codebase to implement it that way.BREAKING CHANGE:
None afaik, all tests in crates/swc complete successfully and anything that depended on the broken implementation would not have worked with a different transformer.
Related issue (if exists):