Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix analysis of nested function-like properties #5963

Merged
merged 5 commits into from Sep 27, 2022
Merged

fix(es/minifier): Fix analysis of nested function-like properties #5963

merged 5 commits into from Sep 27, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 27, 2022

@kdy1 kdy1 added this to the Planned milestone Sep 27, 2022
@kdy1 kdy1 self-assigned this Sep 27, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Preserve this fix(es/minifier): Mark getter property as a nested function Sep 27, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Mark getter property as a nested function fix(es/minifier): Fix analysis of nested function-like properties Sep 27, 2022
@kdy1 kdy1 marked this pull request as ready for review September 27, 2022 07:21
@kdy1 kdy1 enabled auto-merge (squash) September 27, 2022 07:21
kdy1
kdy1 commented Sep 27, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

swc-bot
swc-bot reviewed Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 0fb2c1d into swc-project:main Sep 27, 2022
@kdy1 kdy1 deleted the more branch September 27, 2022 08:38
@kdy1 kdy1 modified the milestones: Planned, v1.3.4 Sep 30, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.4
Development

Successfully merging this pull request may close these issues.

Loses "this" context in getter function with "compress.inline"
2 participants
@kdy1 @swc-bot