fix(es/base): Use seperate mark for FnExpr Ident

[Austaras]

Description:

BREAKING CHANGE:

Related issue (if exists):

[Austaras]

Don't know why this is renamed -- Could you help @kdy1 ?

[kdy1]

Because function name (f) and the parameter (f1) is now in a different scope

[kdy1]

Previously those were treated as identical to each other

[kdy1]

As there's ( in front of function, this is fn expr, not fn decl

[Austaras]

But why do other colliding ident not got renamed?

[kdy1]

At where? We reuse variable names in the name mangler, and we only rename declared identifiers in normal var renamer

[Austaras]

function foo(foo) {}

would remain the same after renamer.

[kdy1]

We are using same analyer for minifier and normal var renamer, and the analyzer knows that you can't refer foo (function) from in foo

[kdy1]

Hmm... you are right I'm not sure why is this renamed.

[kdy1]

I think

swc/crates/swc_ecma_transforms_base/src/rename/analyzer/mod.rs

Lines 155 to 171 in 3d393dd

	fn visit_fn_decl(&mut self, f: &FnDecl) {
	self.add_decl(f.ident.to_id());
	self.with_scope(|v| {
	f.function.visit_with(v);
	})
	}
	fn visit_fn_expr(&mut self, f: &FnExpr) {
	self.with_scope(|v| {
	if let Some(id) = &f.ident {
	v.add_decl(id.to_id());
	}
	f.function.visit_with(v);
	})
	}

is the issue

[kdy1]

Thanks, although I think you need to update more tests.

---

swc-bump:

• swc_ecma_transforms_base

[kdy1]

I think there are room for improvement, but let's split PR.

[kdy1]

We are using same analyer for minifier and normal var renamer, and the analyzer knows that you can't refer foo (function) from in foo

[kdy1]

Hmm... you are right I'm not sure why is this renamed.

[kdy1]

I think

swc/crates/swc_ecma_transforms_base/src/rename/analyzer/mod.rs

Lines 155 to 171 in 3d393dd

	fn visit_fn_decl(&mut self, f: &FnDecl) {
	self.add_decl(f.ident.to_id());
	self.with_scope(|v| {
	f.function.visit_with(v);
	})
	}
	fn visit_fn_expr(&mut self, f: &FnExpr) {
	self.with_scope(|v| {
	if let Some(id) = &f.ident {
	v.add_decl(id.to_id());
	}
	f.function.visit_with(v);
	})
	}

is the issue