Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix skipping logic of sequential inliner #5956

Merged
merged 35 commits into from Sep 26, 2022
Merged

fix(es/minifier): Fix skipping logic of sequential inliner #5956

merged 35 commits into from Sep 26, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 26, 2022 •
edited

Description:

This PR implements is_skippable_for_seq fully.

Related issue:

Investigation

collapse_vars: true is the condition

                        compress: TerserCompressorOptions {
                            defaults: false,
                            collapse_vars: true.into(),
                            ..Default::default()
                        }

this breaks

factor should be inlined to the first usage, but it's instead inlined into second usage.

image

@kdy1 kdy1 added this to the Planned milestone Sep 26, 2022
@kdy1 kdy1 self-assigned this Sep 26, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Fix react-chartjs fix(es/minifier): Fix skipping logic of sequential inliner Sep 26, 2022
kdy1
kdy1 commented Sep 26, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 marked this pull request as ready for review September 26, 2022 13:58
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 26, 2022
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) September 26, 2022 13:59
@kdy1 kdy1 merged commit 9d19742 into swc-project:main Sep 26, 2022
@kdy1 kdy1 deleted the next-chart branch September 26, 2022 15:05
@kdy1 kdy1 mentioned this pull request Sep 27, 2022
Merged
ijjk pushed a commit to vercel/next.js that referenced this pull request Sep 27, 2022
@kdy1
chore: Update swc (#40928)
4f70f3a 
This PR updates swc crates to
swc-project/swc@3d393dd

---

This PR applies

 - swc-project/swc#5954

Closes #40803

 - swc-project/swc#5956

Resolves
#30237 (comment)
@kdy1 kdy1 modified the milestones: Planned, v1.3.4 Sep 30, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.4
Development

Successfully merging this pull request may close these issues.

Next.js Chart.js broken when swcMinify enabled for non-development builds
1 participant
@kdy1