Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix analysis of parameters #5954

Merged
merged 18 commits into from Sep 27, 2022
Merged

fix(es/minifier): Fix analysis of parameters #5954

merged 18 commits into from Sep 27, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 26, 2022 •
edited

Description:

Although the author of the issue talked about @react-pdf/renderer, it's a bug related to brotli, not react pdf renderer.

After investigation, I found that the bug is caused by not marking parameters as initialized. So I fixed the analyzer.

Related issue:

Investigation

This occurs only if inline is true.

                        compress: TerserCompressorOptions {
                            defaults: false,
                            inline: TerserInlineOption::Bool(true).into(),
                            ..Default::default()
                        }

breaks

More investigation

image

start_table should not be replaced with table because table is modified.

image

@kdy1 kdy1 added this to the Planned milestone Sep 26, 2022
@kdy1 kdy1 self-assigned this Sep 26, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Fix brotli fix(es/minifier): Fix analysis of parameters Sep 27, 2022
@kdy1 kdy1 marked this pull request as ready for review September 27, 2022 02:41
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 27, 2022
View reviewed changes
kdy1
kdy1 commented Sep 27, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 enabled auto-merge (squash) September 27, 2022 02:42
swc-bot
swc-bot reviewed Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 mentioned this pull request Sep 27, 2022
Closed
1 task
@kdy1 kdy1 disabled auto-merge September 27, 2022 03:19
@kdy1 kdy1 merged commit 33a15c8 into swc-project:main Sep 27, 2022
@kdy1 kdy1 deleted the minifier-react-pdf branch September 27, 2022 03:19
@kdy1 kdy1 mentioned this pull request Sep 27, 2022
Merged
ijjk pushed a commit to vercel/next.js that referenced this pull request Sep 27, 2022
@kdy1
chore: Update swc (#40928)
4f70f3a 
This PR updates swc crates to
swc-project/swc@3d393dd

---

This PR applies

 - swc-project/swc#5954

Closes #40803

 - swc-project/swc#5956

Resolves
#30237 (comment)
@kdy1 kdy1 modified the milestones: Planned, v1.3.4 Sep 30, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @swc-bot