Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/support-parsing-ts-as-in-destructured-assignment #5948

Conversation

JohnDaly
Copy link
Contributor

Description:

Update reparse_expr_as_pat_inner to handle TsAs expressions for AssignmentElement patterns.

This enables support for the following pattern:

let a;
[a as number] = [1];

Related issue (if exists):
#5947

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kdy1
Copy link
Member

kdy1 commented Sep 25, 2022

Can you sign the CLA?

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 merged commit cdd69d0 into swc-project:main Sep 25, 2022
@kdy1 kdy1 added this to the Planned milestone Sep 25, 2022
@JohnDaly JohnDaly deleted the fix/support-parsing-ts-as-in-destructured-assignment branch September 25, 2022 01:30
@kdy1 kdy1 modified the milestones: Planned, v1.3.4 Sep 30, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants