fix(es/module): improve cjs lexer compatibility #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
previously approved these changes
Jul 1, 2022
|
Ah, node-api test failed. I will update the test cases. |
auto-merge was automatically disabled
July 1, 2022 06:35
Head branch was pushed to by a user without write access
kdy1
approved these changes
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It's a little weird that cjs-module-lexer doesn't recognize exports getter if
enumerable: trueis not the first one.This pull request improve the compatibility with cjs-module-lexer.
https://runkit.com/embed/ez1qzzokityr
BREAKING CHANGE:
Related issue (if exists):