Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add '--features memory_cache' to test steps #5074

Merged
merged 1 commit into from Jun 30, 2022
Merged

docs: Add '--features memory_cache' to test steps #5074

merged 1 commit into from Jun 30, 2022

Conversation

jdmnd
Copy link
Contributor

@jdmnd jdmnd commented Jun 30, 2022

Description:

The existing instructions fail to build swc with this error:

error: Plugin_runner should enable either filesystem, or memory cache

Related issue (if exists):

Fixes #4838

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@kdy1 kdy1 requested a review from kwonoj June 30, 2022 15:00
@kdy1 kdy1 enabled auto-merge (squash) June 30, 2022 16:37
@kdy1 kdy1 added this to the Planned milestone Jun 30, 2022
kdy1
kdy1 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • ''

@kdy1 kdy1 merged commit 9d8beb0 into swc-project:main Jun 30, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.208 Jul 1, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwonoj kwonoj kwonoj approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.208
Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.md needs --features memory_cache
4 participants
@jdmnd @CLAassistant @kwonoj @kdy1