Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/module): support node interop #5069

Merged
merged 8 commits into from Jul 1, 2022
Merged

feat(es/module): support node interop #5069

merged 8 commits into from Jul 1, 2022

Conversation

magic-akari
Copy link
Member

Description:

follow Babel's importInterop

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jun 30, 2022
kdy1
kdy1 reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need interop: "swc"?
I know babel has one, but I'm not sure about adding one more brand.

(Really, just not sure, and this is not a change request)

@magic-akari
Copy link
Member Author

It is the default option.
In most cases, the user does not need to write it explicitly when selecting this option.
Anyway, we need to name it.
It would be a little weird if we used babel as default name.

What name do you prefer?

@kdy1
Copy link
Member

kdy1 commented Jun 30, 2022

I think swc is the best option if so, thank you!

kdy1
kdy1 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_module --breaking

@kdy1 kdy1 enabled auto-merge (squash) July 1, 2022 02:34
swc-bot
swc-bot reviewed Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 1e33dba into swc-project:main Jul 1, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.208 Jul 1, 2022
@magic-akari magic-akari deleted the es/module/interop-node branch July 6, 2022 06:41
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.208
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magic-akari @kdy1 @swc-bot