Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atoms): Improve atoms #5066

Merged
merged 3 commits into from Jun 29, 2022
Merged

feat(atoms): Improve atoms #5066

merged 3 commits into from Jun 29, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 29, 2022

Description:

Related issue (if exists):


main

html/parser_document/css_2021_spec
                        time:   [14.183 ms 14.218 ms 14.261 ms]
Found 14 outliers among 100 measurements (14.00%)
  5 (5.00%) high mild
  9 (9.00%) high severe

html/parser_document/github_com_17_05_2022
                        time:   [5.4104 ms 5.4194 ms 5.4321 ms]
Found 13 outliers among 100 measurements (13.00%)
  6 (6.00%) high mild
  7 (7.00%) high severe

html/parser_document/stackoverflow_com_17_05_2022
                        time:   [4.9527 ms 4.9573 ms 4.9625 ms]
Found 13 outliers among 100 measurements (13.00%)
  1 (1.00%) low mild
  5 (5.00%) high mild
  7 (7.00%) high severe

html/parser_document_fragment/css_2021_spec
                        time:   [14.199 ms 14.219 ms 14.247 ms]
Found 15 outliers among 100 measurements (15.00%)
  5 (5.00%) high mild
  10 (10.00%) high severe

html/parser_document_fragment/github_com_17_05_2022
                        time:   [5.3940 ms 5.3984 ms 5.4035 ms]
Found 12 outliers among 100 measurements (12.00%)
  4 (4.00%) high mild
  8 (8.00%) high severe

html/parser_document_fragment/stackoverflow_com_17_05_2022
                        time:   [4.9630 ms 4.9712 ms 4.9813 ms]
Found 14 outliers among 100 measurements (14.00%)
  6 (6.00%) high mild
  8 (8.00%) high severe

@kdy1 kdy1 added this to the Planned milestone Jun 29, 2022
@kdy1
Copy link
Member Author

kdy1 commented Jun 29, 2022

cc @alexander-akait
The performance is regressed.

I think it will show better performance in real world, but there's one more thing we should try.
We should try expanding static set of swc_atoms

@kdy1 kdy1 changed the title perf(html/ast): Use Atom instead of JsWord feat(atoms): Use Atom instead of JsWord Jun 29, 2022
@kdy1 kdy1 changed the title feat(atoms): Use Atom instead of JsWord feat(atoms): Improve atoms Jun 29, 2022
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_atoms
  • swc_common

@kdy1 kdy1 marked this pull request as ready for review June 29, 2022 11:39
@kdy1 kdy1 enabled auto-merge (squash) June 29, 2022 11:39
@kdy1 kdy1 merged commit 34f4f5a into swc-project:main Jun 29, 2022
@kdy1 kdy1 deleted the css-atom branch June 29, 2022 12:02
@kdy1 kdy1 modified the milestones: Planned, v1.2.208 Jul 1, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant