Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swc/common): add versioned wrapper struct (#5060: Part 1) #5062

Merged
merged 2 commits into from Jun 29, 2022

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Jun 28, 2022

Description:

Related to #5060.

PR introduces a new struct versioned, which is a transparent type can be used to carry over different versioned struct. Also PR wraps ast with bytecheck to validate serialized byte with each versions.

BREAKING CHANGE:

Related issue (if exists):

crates/ast_node/Cargo.toml Outdated Show resolved Hide resolved
@kdy1 kdy1 added this to the Planned milestone Jun 29, 2022
@kwonoj kwonoj force-pushed the feat-versioned-plugin-struct branch from 6f182bb to 08889d3 Compare June 29, 2022 03:14
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_atoms
  • swc_common
  • ast_node --breaking

@kdy1 kdy1 enabled auto-merge (squash) June 29, 2022 03:23
@kdy1 kdy1 merged commit e34a864 into swc-project:main Jun 29, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.208 Jul 1, 2022
@kwonoj kwonoj deleted the feat-versioned-plugin-struct branch July 18, 2022 15:07
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants