Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html/minifier): fixes for smart mode and safe whitespaces #5058

Merged
merged 19 commits into from Jun 29, 2022
Merged

fix(html/minifier): fixes for smart mode and safe whitespaces #5058

merged 19 commits into from Jun 29, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Jun 28, 2022 •
edited

Description:

More fixes and tests:

  • reduce count of retain_mut
  • fix bugs with whitespaces and comments
  • more tests

BREAKING CHANGE:

No

Related issue (if exists):

No

@kdy1 kdy1 added this to the Planned milestone Jun 29, 2022
@alexander-akait alexander-akait marked this pull request as ready for review June 29, 2022 04:02
kdy1
kdy1 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_html_minifier

@kdy1 kdy1 enabled auto-merge (squash) June 29, 2022 11:46
swc-bot
swc-bot reviewed Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit e9bad20 into swc-project:main Jun 29, 2022
@alexander-akait alexander-akait deleted the test-more branch June 29, 2022 16:11
@kdy1 kdy1 modified the milestones: Planned, v1.2.208 Jul 1, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.208
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot