Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): this in function with block scoped vars #5056

Merged
merged 3 commits into from Jun 29, 2022
Merged

fix(es/compat): this in function with block scoped vars #5056

merged 3 commits into from Jun 29, 2022

Conversation

Austaras
Copy link
Member

Description:

One could see that babel uses unwrapFunctionEnvironment here too.

BREAKING CHANGE:

Related issue (if exists):
closes #5048

kdy1
kdy1 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for the late review, I was too busy.

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 added this to the Planned milestone Jun 29, 2022
@kdy1 kdy1 enabled auto-merge (squash) June 29, 2022 03:09
swc-bot
swc-bot reviewed Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 18ea2b5 into swc-project:main Jun 29, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.208 Jul 1, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.208
Development

Successfully merging this pull request may close these issues.

lose this inside function declare
3 participants
@Austaras @kdy1 @swc-bot