feat(ecma/parser): add the allow_return_outside_function option
#5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
reviewed
Jun 28, 2022
crates/swc_html_minifier/src/lib.rs
Outdated
| @@ -1069,6 +1073,13 @@ impl Minifier { | |||
| } | |||
| }; | |||
|
|
|||
| println!("{:?}", errors); | |||
|
@kdy1 Fixed and rebase |
alexander-akait
force-pushed
the
feat-es-allow_return_outside_function
branch
from
fe97b07
to
5158b35
Compare
kdy1
reviewed
Jun 29, 2022
crates/swc_ecma_parser/src/lib.rs
Outdated
| @@ -256,6 +256,16 @@ impl Syntax { | |||
| } | |||
| } | |||
|
|
|||
| pub fn allow_return_outside_function(self) -> bool { | |||
There was a problem hiding this comment.
Please reduce visibility of this to pub(crate)
|
@kdy1 Fixed |
kdy1
approved these changes
Jun 29, 2022
swc-bot
reviewed
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
allow_return_outside_functionto parse HTML event handler attributesBREAKING CHANGE:
Yes
Related issue (if exists):
No