Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html/minifier): sort unordered values of attributes and option for it #5035

Merged
merged 7 commits into from Jun 30, 2022

Conversation

alexander-akait
Copy link
Collaborator

Description:

Sorting of unordered is safe, we already sort clases, here we sort more attributes + option for this

BREAKING CHANGE:

Yes

Related issue (if exists):

No

@alexander-akait alexander-akait changed the title feat(html/minfiier): sort unordered values of attributes and option for it feat(html/minifier): sort unordered values of attributes and option for it Jun 24, 2022
@kdy1 kdy1 added this to the Planned milestone Jun 25, 2022
@alexander-akait
Copy link
Collaborator Author

@kdy1 Fixed + rename the option to sort_space_separated_attribute_values, it is more clear

@alexander-akait
Copy link
Collaborator Author

@kdy1 Rebased too

@alexander-akait
Copy link
Collaborator Author

@kdy1 Rebased, will be great to review ⭐

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_ecma_minifier --breaking

@kdy1 kdy1 enabled auto-merge (squash) June 30, 2022 01:23
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 26cfeff into swc-project:main Jun 30, 2022
@alexander-akait alexander-akait deleted the feat-add-sort_classes-option branch June 30, 2022 19:33
@kdy1 kdy1 modified the milestones: Planned, v1.2.208 Jul 1, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants