Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): parentheses in assignment target #4105

Merged
merged 4 commits into from
Mar 20, 2022
Merged

fix(es/parser): parentheses in assignment target #4105

merged 4 commits into from
Mar 20, 2022

Conversation

hanneslund
Copy link
Contributor

Description:
Related issue (if exists):
closes #2834

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@kdy1
Copy link
Member

kdy1 commented Mar 20, 2022

Please run UPDATE=1 cargo test from ./crates/swc_ecma_parser

@kdy1
Copy link
Member

kdy1 commented Mar 20, 2022

Oh sorry it was about error reporting test.
You can remove the test file instead

@hanneslund
Copy link
Contributor Author

I did UPDATE=1 cargo test, I think they are ok to keep?

@kdy1
Copy link
Member

kdy1 commented Mar 20, 2022

Yeah it seems like, thank you!

kdy1
kdy1 approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 added this to the v1.2.160 milestone Mar 20, 2022
@kdy1 kdy1 enabled auto-merge (squash) March 20, 2022 11:34
@kdy1 kdy1 merged commit d38117d into swc-project:main Mar 20, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.160
Development

Successfully merging this pull request may close these issues.

Error: Not a Pattern
3 participants
@hanneslund @CLAassistant @kdy1