Update line number start to 0 #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kdy1
requested changes
Mar 19, 2022
|
Updating failing tests. |
|
@kdy1 do you know if there is a way of generating the
I see that there's a total of 1084 files. Would be very time consuming to fix all manually. |
|
You can run `UPDATE=1 cargo test`
It's in contributing.md
2022년 3월 19일 (토) 오후 4:09, Edwin Coronado ***@***.***>님이 작성:
… @kdy1 <https://github.com/kdy1> do you know if there is a way of
generating the *.stderr files programmatically? After running this in
root directory:
find . -name '*stderr' | wc -l
I see that there's a total of 1084 files. Would be very time consuming to
fix all manually.
—
Reply to this email directly, view it on GitHub
<#4082 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHELSJ7K5QPBEAL7OIQL5G3VAV4S7ANCNFSM5RCXCGHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
kdy1
requested changes
Mar 19, 2022
| @@ -109,7 +109,7 @@ impl SourceCode for MietteSourceCode<'_> { | |||
| _cm: self.0, | |||
| data: src, | |||
| span: convert_span(span), | |||
| line: loc.line, | |||
| line: loc.line - 1, | |||
There was a problem hiding this comment.
Can you use saturating_sub instead?
There was a problem hiding this comment.
I'll update/merge this PR as this is required for other PRs
kdy1
previously approved these changes
Mar 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes issue #4081 by starting line number at 0 instead of 1 since Miette increments the line.
Related issue (if exists):
Closes #4081