Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/lint): implement use-isnan rule #4080

Merged
merged 14 commits into from
Mar 21, 2022
Merged

feat(es/lint): implement use-isnan rule #4080

merged 14 commits into from
Mar 21, 2022

Conversation

ArturAralin
Copy link
Contributor

Description:

Implement use-isnan rule

BREAKING CHANGE:

No

kdy1
kdy1 requested changes Mar 19, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

crates/swc_ecma_lints/src/rules/use_is_nan.rs Show resolved Hide resolved
kdy1
kdy1 previously approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

swc-bump:

  • swc_ecma_lints

@kdy1 kdy1 added this to the v1.2.160 milestone Mar 20, 2022
@kdy1 kdy1 enabled auto-merge (squash) March 20, 2022 06:35
@kdy1 kdy1 disabled auto-merge March 20, 2022 06:51
@kdy1
Copy link
Member

kdy1 commented Mar 20, 2022

Can you rebase?

kdy1
kdy1 approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_lints

@kdy1 kdy1 enabled auto-merge (squash) March 21, 2022 10:52
@kdy1 kdy1 disabled auto-merge March 21, 2022 10:52
@kdy1 kdy1 enabled auto-merge (squash) March 21, 2022 10:52
swc-bot
swc-bot reviewed Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit dd862ba into swc-project:main Mar 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.160
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArturAralin @kdy1 @swc-bot