Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css/ast): improve unicode range AST #3757

Merged
merged 3 commits into from Feb 27, 2022
Merged

feat(css/ast): improve unicode range AST #3757

merged 3 commits into from Feb 27, 2022

Conversation

alexander-akait
Copy link
Collaborator

Description:

Improve urange parsing, split them on two values - start and end.

Props:

  • better AST
  • no need to split them on minifier side, because we can do it on parsing side
  • better error messages and validate them

BREAKING CHANGE:

Yes

Related issue (if exists):

No

alexander-akait
alexander-akait commented Feb 26, 2022
View reviewed changes
crates/swc_css_minifier/tests/fixture/compress-urange/output.min.css
@@ -1 +1 @@
@font-face{unicode-range:U+26}@font-face{unicode-range:U+-7F}@font-face{unicode-range:U+25-FF}@font-face{unicode-range:U+25-FF,U+4??}@font-face{unicode-range:U+10????}@font-face{unicode-range:U+2b??}@font-face{unicode-range:U+2b??}@font-face{unicode-range:U+1e??}@font-face{unicode-range:U+2125-2128}@font-face{unicode-range:U+4??}@font-face{unicode-range:U+25-FF,U+4??}@font-face{unicode-range:U+450-4FF}@font-face{unicode-range:U+A5,U+4E00-9FFF,U+30??,U+FF00-FF9F}@font-face{unicode-range:U+????}@font-face{unicode-range:U+????}@font-face{unicode-range:U+10????}@font-face{unicode-range:U+10????}@font-face{unicode-range:U+1e1e?}@font-face{unicode-range:U+????,U+1????,U+10????}@font-face{unicode-range:U+25}@font-face{unicode-range:U+1e1e?}@font-face{unicode-range:U+25}@font-face{unicode-range:U+125}@font-face{unicode-range:U+100-FFFF}@font-face{unicode-range:U+10125}@font-face{unicode-range:U+450-4FF}@font-face{unicode-range:U+450-4FF}@font-face{unicode-range:U+450-4FF}
@font-face{unicode-range:U+26}@font-face{unicode-range:U+-7F}@font-face{unicode-range:U+25-FF}@font-face{unicode-range:U+25-FF,U+4??}@font-face{unicode-range:U+10????}@font-face{unicode-range:U+2b??}@font-face{unicode-range:u+2b??}@font-face{unicode-range:U+1e??}@font-face{unicode-range:U+2125-2128}@font-face{unicode-range:U+4??}@font-face{unicode-range:U+25-FF,U+4??}@font-face{unicode-range:U+450-4FF}@font-face{unicode-range:U+A5,U+4E00-9FFF,U+30??,U+FF00-FF9F}@font-face{unicode-range:U+????}@font-face{unicode-range:U+????}@font-face{unicode-range:U+10????}@font-face{unicode-range:U+10????}@font-face{unicode-range:U+1e1e?}@font-face{unicode-range:u+????,U+1????,U+10????}@font-face{unicode-range:U+25}@font-face{unicode-range:U+1e1e?}@font-face{unicode-range:U+25}@font-face{unicode-range:U+125}@font-face{unicode-range:U+100-FFFF}@font-face{unicode-range:U+10125}@font-face{unicode-range:U+450-4FF}@font-face{unicode-range:U+450-4FF}@font-face{unicode-range:U+450-4FF}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we don't transform U/u and keep them as they were in AST after minification

alexander-akait
alexander-akait commented Feb 26, 2022
View reviewed changes
crates/swc_css_parser/src/parser/value/mod.rs
@@ -1358,13 +1358,13 @@ where
// u <number-token> <dimension-token> |
// u <number-token> <number-token> |
// u '+' '?'+
impl<I> Parse<Urange> for Parser<I>
impl<I> Parse<UnicodeRange> for Parser<I>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just better name

@alexander-akait alexander-akait changed the title refactor: code refactor: unicode range Feb 26, 2022
@alexander-akait alexander-akait changed the title refactor: unicode range feat(css/ast): improve unicode range AST Feb 26, 2022
kdy1
kdy1 approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_css_ast --breaking

@kdy1 kdy1 enabled auto-merge (squash) February 27, 2022 05:04
@kdy1 kdy1 added this to the v1.2.146 milestone Feb 27, 2022
@kdy1 kdy1 disabled auto-merge February 27, 2022 05:15
@kdy1 kdy1 merged commit 91cf965 into swc-project:main Feb 27, 2022
@alexander-akait alexander-akait deleted the feat-improve-unicode-range-parsing branch February 27, 2022 14:12
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.146
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexander-akait @kdy1