feat(swc/cli): add trace configuration for compile #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
requested changes
Feb 26, 2022
| @@ -259,6 +291,8 @@ impl super::CommandRunner for CompileOptions { | |||
| } | |||
|
|
|||
| if let Some(stdin_input) = stdin_input { | |||
| let span = tracing::span!(tracing::Level::TRACE, "compile_stdin"); | |||
| let _ = span.enter(); | |||
There was a problem hiding this comment.
thanks for catch, I forgot to update this along with non-stdin input spans.
kwonoj
force-pushed
the
feat-cli-trace
branch
from
c9f0f3f
to
5e63c02
Compare
kwonoj
force-pushed
the
feat-cli-trace
branch
from
5e63c02
to
d91cd33
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enables trace for the cli as well, via
--experimental-traceboolean flag.Related issue (if exists):