fix(swc/plugin_macro): do not dupe free guest memory #3732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Peeking execution path, I realized I left over
_volatile
fn in macro when I updated return value logic from multivalue to calling imported fn from host. This change removed logic host allocates byte for returned value that guest no longer need manually free, instead rust will drop allocated serialized bytes accordingly.Related issue (if exists):
#3598 (comment)