New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custom instanceof Handler result should be cast to boolean #3728
fix: custom instanceof Handler result should be cast to boolean #3728
Conversation
9b9f915
to
8cd01c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
swc-bump:
- swc_ecma_transforms_base
8cd01c1
to
7d19049
Compare
Please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as change requested
I didn't get any fails:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_ecma_transforms_base
@kdy1 🙏 I would like to ask if I can run |
Yes, I think the |
Description:
helper.instanceof
does not cast[Symbol.hasInstance]
call to booleanRelated issue (if exists):
Also: If need to add a test case, please tell me how to do it, I may not know the situation.